Support MetadataType Attribute #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
sungam3r
reviewed
Dec 20, 2024
Fine with me Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
sungam3r
reviewed
Dec 20, 2024
Thank you. Much better explaination! Actually this is my first contribution to such a project... Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
sungam3r
reviewed
Dec 20, 2024
sungam3r
reviewed
Dec 20, 2024
sungam3r
reviewed
Dec 20, 2024
src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicy.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Dec 20, 2024
src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicy.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Dec 20, 2024
src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicy.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Dec 22, 2024
sungam3r
reviewed
Dec 22, 2024
src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicyOptions.cs
Show resolved
Hide resolved
sungam3r
reviewed
Dec 22, 2024
src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicyOptions.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Dec 22, 2024
src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicyOptions.cs
Outdated
Show resolved
Hide resolved
…gPolicyOptions.cs Fine with me Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
|
@digitalsigi I suggest you to take my changes from destructurama:metadata into your branch and retarget it to |
|
I'll be glad to do so, but need first to find out how to do that. I am not so experienced in this corner ... |
…gPolicyOptions.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
…gPolicyOptions.cs Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Need additional review Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
|
I managed to create a new branch 'metadatatype' in my forked repo. Is it OK to open a new PR or do I have to do other things before? |
|
Up to you. |
I created a new branch and submitted a new PR. In this PR i saw a conflict but have no idea how to resolve. It looks like that there are changes in both master and PR. Could you please help me here? Thank you in advance |
|
Replaced by #142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support from MetadataType Attribute, see #40
According to https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.dataannotations.metadatatypeattribute?view=net-9.0#remarks
Changed code replaces the PropertyInfo from base class with PropertyInfo property of MetadataType for equal named properties.